Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: submit batch keep retrying even though batch accepted event received #253

Merged
merged 1 commit into from
Feb 17, 2023

Conversation

omritoptix
Copy link
Contributor

No description provided.

@omritoptix omritoptix requested a review from a team as a code owner February 16, 2023 18:22
@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #253 (e9cca6e) into main (d93b63e) will increase coverage by 0.18%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
+ Coverage   52.01%   52.19%   +0.18%     
==========================================
  Files          70       70              
  Lines       12471    12485      +14     
==========================================
+ Hits         6487     6517      +30     
+ Misses       5064     5049      -15     
+ Partials      920      919       -1     
Impacted Files Coverage Δ
block/manager.go 67.22% <100.00%> (+2.96%) ⬆️
rpc/json/ws.go 61.90% <0.00%> (+7.93%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@omritoptix omritoptix changed the title fix: submit batch keep retrying though batch accepted event received fix: submit batch keep retrying even though batch accepted event received Feb 17, 2023
@omritoptix omritoptix merged commit e6f489c into main Feb 17, 2023
@omritoptix omritoptix deleted the omritoptix/252-stop-batch-retry-on-state-update branch February 17, 2023 11:02
@omritoptix omritoptix linked an issue Feb 19, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dymint panics due to wrong logging
2 participants