Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Updated dymension client to accept gas limit, fee and prices params. #243

Merged
merged 2 commits into from
Feb 14, 2023

Conversation

omritoptix
Copy link
Contributor

No description provided.

@omritoptix omritoptix changed the title WIP: Updated dymension client to accept gas limit, fee and prices params. feat: Updated dymension client to accept gas limit, fee and prices params. Feb 14, 2023
@codecov
Copy link

codecov bot commented Feb 14, 2023

Codecov Report

Merging #243 (3511d1c) into main (39e64d7) will increase coverage by 0.04%.
The diff coverage is 0.00%.

❗ Current head 3511d1c differs from pull request most recent head 067f563. Consider uploading reports for the commit 067f563 to get more accurate results

@@            Coverage Diff             @@
##             main     #243      +/-   ##
==========================================
+ Coverage   52.02%   52.06%   +0.04%     
==========================================
  Files          70       70              
  Lines       12465    12468       +3     
==========================================
+ Hits         6485     6492       +7     
+ Misses       5059     5057       -2     
+ Partials      921      919       -2     
Impacted Files Coverage Δ
settlement/dymension/dymension.go 21.53% <0.00%> (-0.24%) ⬇️
block/manager.go 64.25% <0.00%> (+1.33%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@omritoptix omritoptix marked this pull request as ready for review February 14, 2023 11:08
@omritoptix omritoptix requested a review from a team as a code owner February 14, 2023 11:08
@liorzilp liorzilp merged commit a738e1d into main Feb 14, 2023
@liorzilp liorzilp deleted the omritoptix/242-gas-config-support branch February 14, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for setting fees and gas limit/prices when sending tx to the hub
2 participants