Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Reactivating Review Apps to check if it works. #421

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
120 changes: 60 additions & 60 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -61,68 +61,68 @@ jobs:



# # DEPLOY THE REVIEW APP
# # This will deploy an app to fly.io with the name 'mvp-pr-$PR_NUMBER' (check `review-apps.sh` script).
# review_app:

# # Only run when it's not a dependabot PR
# if: github.event.pull_request.user.login != 'dependabot[bot]'

# name: Review App Job
# runs-on: ubuntu-latest
# # needs: [build]
# steps:
# - name: Checkout repository
# uses: actions/checkout@v3

# - name: Install flyctl
# uses: superfly/flyctl-actions/setup-flyctl@master

# - name: Set up Elixir
# uses: erlef/setup-beam@v1
# with:
# otp-version: 24.3.4
# elixir-version: 1.14.1

# - name: Run Review App Script
# run: ./.github/scripts/review-apps.sh
# env:
# ENCRYPTION_KEYS: ${{ secrets. ENCRYPTION_KEYS }}
# AUTH_API_KEY: ${{ secrets.FLY_AUTH_API_KEY }}
# APP_NAME: ${{ format('mvp-pr-{0}', github.event.number) }}
# EVENT_ACTION: ${{ github.event.action }}
# FLY_API_TOKEN: ${{ secrets.FLY_API_TOKEN }}
# FLY_ORG: dwyl-mvp
# FLY_REGION: lhr
# FLY_POSTGRES_NAME: mvp-db
# DEPLOY THE REVIEW APP
# This will deploy an app to fly.io with the name 'mvp-pr-$PR_NUMBER' (check `review-apps.sh` script).
review_app:

# Only run when it's not a dependabot PR
if: github.event.pull_request.user.login != 'dependabot[bot]'

name: Review App Job
runs-on: ubuntu-latest
# needs: [build]
steps:
- name: Checkout repository
uses: actions/checkout@v3

- name: Install flyctl
uses: superfly/flyctl-actions/setup-flyctl@master

- name: Set up Elixir
uses: erlef/setup-beam@v1
with:
otp-version: 24.3.4
elixir-version: 1.14.1

- name: Run Review App Script
run: ./.github/scripts/review-apps.sh
env:
ENCRYPTION_KEYS: ${{ secrets. ENCRYPTION_KEYS }}
AUTH_API_KEY: ${{ secrets.FLY_AUTH_API_KEY }}
APP_NAME: ${{ format('mvp-pr-{0}', github.event.number) }}
EVENT_ACTION: ${{ github.event.action }}
FLY_API_TOKEN: ${{ secrets.FLY_API_TOKEN }}
FLY_ORG: dwyl-mvp
FLY_REGION: lhr
FLY_POSTGRES_NAME: mvp-db


# API DEFINITION TESTING - https://docs.hoppscotch.io/cli
# NOTE: The tests are executed sequentially in each folder
# but all the sequence of folders are run in reverse order of what's displayed in the GUI.
# We've made use of env variables to make it work. Take this into account if you want to add more requests.
# api_definition:

# # Only run when not closed
# if: github.event.pull_request.action != 'closed'

# name: API Definition Tests
# runs-on: ubuntu-latest
# needs: [review_app]
# steps:
# - uses: actions/checkout@v3

# # After the app is deployed, we need to change the host
# # in the `lib/api/fly_dev.json` so the API tests work and target the deployed app.
# - name: Update lib/api/fly_dev.json description
# uses: jossef/[email protected]
# with:
# file: ./lib/api/fly_dev.json
# field: host
# value: ${{ format('https://mvp-pr-{0}.fly.dev', github.event.number) }}

# - name: Install Hoppscotch CLI
# run: npm i -g @hoppscotch/[email protected]

# - name: Running server and Hoppscotch Tests
# run: hopp test -e ./lib/api/fly_dev.json ./lib/api/MVP.json
api_definition:

# Only run when not closed
if: github.event.pull_request.action != 'closed'

name: API Definition Tests
runs-on: ubuntu-latest
needs: [review_app]
steps:
- uses: actions/checkout@v3

# After the app is deployed, we need to change the host
# in the `lib/api/fly_dev.json` so the API tests work and target the deployed app.
- name: Update lib/api/fly_dev.json description
uses: jossef/[email protected]
with:
file: ./lib/api/fly_dev.json
field: host
value: ${{ format('https://mvp-pr-{0}.fly.dev', github.event.number) }}

- name: Install Hoppscotch CLI
run: npm i -g @hoppscotch/[email protected]

- name: Running server and Hoppscotch Tests
run: hopp test -e ./lib/api/fly_dev.json ./lib/api/MVP.json
Loading