Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use exists? instead of Array#include? method #77

Open
pjmartorell opened this issue Jul 9, 2019 · 0 comments
Open

Use exists? instead of Array#include? method #77

pjmartorell opened this issue Jul 9, 2019 · 0 comments

Comments

@pjmartorell
Copy link

pjmartorell commented Jul 9, 2019 •
edited
Loading

groupify/lib/groupify/adapter/active_record/group.rb

Line 38 in f2c64af

member.groups << self unless member.groups.include?(self)

exists? is more suitable to check if a given record already exists en the database, compared to Array#include?, which loads all records in the relation and loops over it
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pjmartorell