Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad URL decoding on tags leading to wrong major version #99

Closed
TheBlusky opened this issue Apr 24, 2023 · 2 comments
Closed

Bad URL decoding on tags leading to wrong major version #99

TheBlusky opened this issue Apr 24, 2023 · 2 comments

Comments

@TheBlusky
Copy link

Hi ! Pretty nice work on this module, letting me auto update dependencies on projects.

I came accross a bug on some repositories, for eg., when I do python -m lastversion n8n-io/n8n, I get 400.222.3 as a result, but it should be 0.222.3 (as of 2023/04/24).

When digging why I get this behavior with verbose, I have the following line :

lastversion.GitHubRepoSession - INFO - Got HTTP status code 200 from https://api.github.com/repos/n8n-io/n8n/releases/tags/n8n%400.223.3

So n8n%400.223.3 is interpreted as 400.223.3 instead of 0.223.3 because %40 is treated as 40 instead of @ (url decoding)

@TheBlusky TheBlusky changed the title Bag URL decoding on tags leading to wrong major version Bad URL decoding on tags leading to wrong major version Apr 24, 2023
@dvershinin
Copy link
Owner

@TheBlusky that is fixed in the latest release. Please try it out.

@TheBlusky
Copy link
Author

I can confirm that it's now fixed. Thank you for your reactivity :-)

Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants