Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong version parsing with number in name #102

Closed
danyeaw opened this issue May 27, 2023 · 2 comments
Closed

Wrong version parsing with number in name #102

danyeaw opened this issue May 27, 2023 · 2 comments

Comments

@danyeaw
Copy link

danyeaw commented May 27, 2023

If libraries have a number in their name, they get parsed as part of the version.

lastversion.lastversion - INFO - Verbose 1 level output.
lastversion.ProjectHolder - INFO - Using cache directory: C:\Users\dan\AppData\Local\lastversion\lastversion\Cache.
lastversion.ProjectHolder - INFO - Created instance of GitHubRepoSession
lastversion.GitHubRepoSession - INFO - Using API token.
lastversion.GitHubRepoSession - INFO - Got HTTP status code 200 from https://github.com/libssh2/libssh2/releases.atom
lastversion.GitHubRepoSession - INFO - Checking tag libssh2-1.10.0
lastversion.ProjectHolder - INFO - Sanitizing string libssh2-1.10.0 as a satisfying version.
lastversion.ProjectHolder - INFO - Parsed as Version OK. String representation: 2.1.10.0.

I was expecting that the representation should be 1.10.0 instead of 2.1.10.0.

@dvershinin
Copy link
Owner

Was fixed in v3.0.0

@danyeaw
Copy link
Author

danyeaw commented Jun 23, 2023

Thanks @dvershinin!!

@danyeaw danyeaw closed this as completed Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants