-
-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use proc_macro's impl FromStr for Literal once Rust 1.53 is stable #287
Comments
@dtolnay we are getting a compilation error with the latest proc-macro2 release:
Full run error can be accessed at https://github.com/apache/arrow-datafusion/runs/3472141634. Could you give some tips on how to workaround this problem? |
For me, using toolchain |
Thanks @smoelius , if I read the code correctly, it should work for stable rust version >= 1.53. But we are still getting the error with rust 1.54, so I feel like something is off here. |
In #286, we implemented
impl FromStr for Literal
in terms ofimpl FromStr for TokenStream
. The upstream PR rust-lang/rust#84717 adds a realimpl FromStr for Literal
to libproc_macro; we should use it once available in a release.The text was updated successfully, but these errors were encountered: