Skip to content
This repository has been archived by the owner on May 19, 2019. It is now read-only.

Relation to the atty crate? #15

Closed
alexcrichton opened this issue Sep 9, 2018 · 2 comments
Closed

Relation to the atty crate? #15

alexcrichton opened this issue Sep 9, 2018 · 2 comments

Comments

@alexcrichton
Copy link
Contributor

I'm not personally knowledgeable of the development history of this vs the atty crate, but we're in a weird situation in the Rust repository where the RLS uses isatty and rustc/Cargo uses atty (I think atty is also used by ripgrep?). It looks like atty differs namely in terms of "weird MSYS detection", although I suspect it's basically equivalent otherwise.

I'm curious, do you know the history here perhaps? I've been surprised by the sheer number of crates that do terminal things (and sad that some, not this library, have spotty support for some platforms). It'd be good if we could consolidate efforts perhaps!

@dtolnay
Copy link
Owner

dtolnay commented Sep 9, 2018

I don't recall finding atty at the time that I needed this functionality for cargo expand -- softprops/atty#29. Today the main difference would be the licenses. atty is MIT while isatty is MIT OR Apache 2.0. I would suggest asking atty for a dual license and consolidating on that.

@alexcrichton
Copy link
Contributor Author

Aha excellent point! Thanks for the info, I'll open an issue with atty

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants