Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs for cluster major events #2829

Closed
adiholden opened this issue Apr 3, 2024 · 2 comments
Closed

Add logs for cluster major events #2829

adiholden opened this issue Apr 3, 2024 · 2 comments
Assignees

Comments

@adiholden
Copy link
Collaborator

No description provided.

@adiholden adiholden added this to the dfly cluster v2 milestone Apr 3, 2024
@chakaz chakaz changed the title Add logs Add logs for cluster major events Apr 4, 2024
@chakaz
Copy link
Collaborator

chakaz commented Apr 4, 2024

To give some more context here:

Yesterday we had a brainstorming session in which we discussed what needs to be logged to help future debugging / investigations. Specifically we wanted to make sure that dangerous / important events are covered well by logs.

We compiled the below list. Note that some logs already exist, so we only need to add logs (including important parameters) where missing.

  • Connection breakdown (migration / replication)
  • Print all cluster config pushes, with an option to show diff from previously set config (like new nodes, new slots, migration, etc)
  • Migration related events: rollback, stop / cancel, finalization
  • flush slots that is done not due to successfully finalizing a migration (like in the case of config that cancels a migration)
  • All DFLYCLUSTER commands with their arguments
  • Apply config which reverts an already finalized migration, causing a data loss on the target node

@chakaz
Copy link
Collaborator

chakaz commented Jun 5, 2024

As part of this issue, we should also include cluster .cc files in default --vmodule

chakaz added a commit that referenced this issue Jun 6, 2024
chakaz added a commit that referenced this issue Jun 6, 2024
@chakaz chakaz closed this as completed Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants