Skip to content

Commit

Permalink
chore: upload all the logs from /tmp
Browse files Browse the repository at this point in the history
Signed-off-by: Roman Gershman <[email protected]>
  • Loading branch information
romange committed Jul 3, 2024
1 parent 3506ee0 commit 08f57bf
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/regression-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ jobs:
uses: actions/upload-artifact@v4
with:
name: logs
path: /tmp/failed/*
path: /tmp/dragonfly.*

lint-test-chart:
runs-on: ubuntu-latest
Expand Down
4 changes: 3 additions & 1 deletion tests/dragonfly/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
from copy import deepcopy

from pathlib import Path
from tempfile import TemporaryDirectory
from tempfile import TemporaryDirectory, gettempdir

from .instance import DflyInstance, DflyParams, DflyInstanceFactory, RedisServer
from . import PortPicker, dfly_args
Expand Down Expand Up @@ -82,6 +82,7 @@ def df_factory(request, tmp_dir, test_env) -> DflyInstanceFactory:
"""
Create an instance factory with supplied params.
"""
os.makedirs(os.path.join(gettempdir(), "tiered"), exist_ok=True)
scripts_dir = os.path.dirname(os.path.abspath(__file__))
path = os.environ.get("DRAGONFLY_PATH", os.path.join(scripts_dir, "../../build-dbg/dragonfly"))

Expand Down Expand Up @@ -327,6 +328,7 @@ def with_ca_tls_client_args(with_tls_client_args, with_tls_ca_cert_args):


def copy_failed_logs_and_clean_tmp_folder(report):
return # TODO: to fix it first and then enable it.
failed_path = "/tmp/failed"
path_exists = os.path.exists(failed_path)
if not path_exists:
Expand Down
3 changes: 2 additions & 1 deletion tests/dragonfly/tiering_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
from .utility import info_tick_timer


BASIC_ARGS = {"port": 6379, "proactor_threads": 4, "tiered_prefix": "/tmp/tiering_test_backing"}
BASIC_ARGS = {"port": 6379, "proactor_threads": 4, "tiered_prefix": "/tmp/tiered/backing"}


@pytest.mark.skip("Requires evaluating runner performance first")
Expand Down Expand Up @@ -43,6 +43,7 @@ async def test_basic_memory_usage(async_client: aioredis.Redis):
assert (
info["used_memory_rss"] < 500 * 1024 * 1024
) # the grown table itself takes up lots of space
assert False


@pytest.mark.opt_only
Expand Down

0 comments on commit 08f57bf

Please sign in to comment.