I believe you missed some tests in your PR :(

Please hurry up! This seams to break the jsdom <3

That's it, jsdom install this update automatically and it breaks. I've tried to make the change in this PR manually and I'm getting another error. NodeList is undefined.

There are some instanceof trying to use NodeList class, but it's undefined, the same way than document was undefined.

Where were the test cases for this particular scenario, when you needed them the most? :'(

@ALL pushed change in 2.2.15
New toNodeList() method functionality disabled via Config object, Config.ANODELIST: false,

Any update on it? it's break the Jsdom

Please fix ASAP

@ALL pushed change in 2.2.15 New toNodeList() method functionality disabled via Config object, Config.ANODELIST: false,

Not sure, if it is supposed to fix the issue with jsdom, but with latest version of nwsapi I am still getting this error while running jest tests with jsdom.

  ● Test suite failed to run

    The error below may be caused by using the wrong test environment, see https://jestjs.io/docs/configuration#testenvironment-string.
    Consider using the "jsdom" test environment.
    
    ReferenceError: document is not defined

      at node_modules/nwsapi/src/nwsapi.js:215:21
      at Factory (node_modules/nwsapi/src/nwsapi.js:245:6)

For me as well, version 2.2.15
ReferenceError: document is not defined at node_modules/nwsapi/src/nwsapi.js:215:21\

@dperini any reason this wouldn't address the issue. global.document is used elsewhere and isn't causing build issues in Node.js, so I assume this would work, but perhaps it's a naive approach?

@dperini any reason this wouldn't address the issue. global.document is used elsewhere and isn't causing build issues in Node.js, so I assume this would work, but perhaps it's a naive approach?

I'm agree. This library can be used in Node.js environment (jsdom for example) and you can't use document, you must use global.document.

@blackrabbit99 feel free to add tests if you know how. I see a lot of directories without updates for 7 years, so I'm not sure. Perhaps @dperini can comment on this.

Setting Config.ANODELIST to false also fixes the problem but 2.2.15 still has Config.ANODELIST to true (in npm repository).

Setting Config.ANODELIST to false also fixes the problem but 2.2.15 still has Config.ANODELIST to true (in npm repository).

Sorry, 2.2.15 has Config.ANODELIST to false, but doesn't resolve the problem.

That's because document.createFragment is always called on bootstrap (ignoring the Config property):

https://github.com/ALL pushed change in 2.2.16
createDocumentFragment() invoked on "global.document".

Open source at its finest!