Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default to not sign source-build VMR legs #4685

Closed
Tracked by #3708
ViktorHofer opened this issue Oct 21, 2024 · 2 comments · Fixed by dotnet/sdk#44489
Closed
Tracked by #3708

Default to not sign source-build VMR legs #4685

ViktorHofer opened this issue Oct 21, 2024 · 2 comments · Fixed by dotnet/sdk#44489
Assignees

Comments

@ViktorHofer
Copy link
Member

Right now we explicitly need to set sign: false in the source-build VMR legs. We should make this the default for source-build so that we don't have to set that parameter.

Example: https://github.com/dotnet/sdk/blob/1c88a979b7109d83e5317b0e374c8d13ef2b3b68/eng/pipelines/templates/stages/vmr-build.yml#L103

cc @mmitche @MichaelSimons

Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

1 similar comment
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants