Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime-community leg failing for ThreadPoolMinMaxThreadsEventTest #71173

Closed
tannergooding opened this issue Jun 22, 2022 · 9 comments
Closed

Comments

@tannergooding
Copy link
Member

This has been failing since #70063 (https://dev.azure.com/dnceng/public/_build/results?buildId=1831349&view=ms.vss-test-web.build-test-results-tab).

CC. @eduardo-vp

@dotnet-issue-labeler
Copy link

I couldn't figure out the best area label to add to this issue. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the untriaged New issue has not been triaged by the area owner label Jun 22, 2022
@tannergooding
Copy link
Member Author

Notably the community leg is for linux release s390x mono. It represents a big endian platform.

@uweigand
Copy link
Contributor

Thanks for reporting this!

Looking at the failing test, we have this failed assertion:

          Child exception:
            Xunit.Sdk.EqualException: Assert.Equal() Failure
          Expected: 3
          Actual:   768
          /home/uweigand/runtime/src/libraries/System.Threading.ThreadPool/tests/ThreadPoolTests.cs(1147,0): at System.Threading.ThreadPools.Tests.ThreadPoolTests.<>c.<ThreadPoolMinMaxThreadsEventTest>b__42_0()

Note that 768 is 0x300 and this value is of type uint16_t, so it looks like a missed endian conversion.

I think this is related to the general endian problems with eventpipe that @stefan-sf has been working on for a while, see in particular #68648. @stefan-sf can you confirm that that PR would fix this new issue as well?

@ghost
Copy link

ghost commented Jun 23, 2022

Tagging subscribers to this area: @mangod9
See info in area-owners.md if you want to be subscribed.

Issue Details

This has been failing since #70063 (https://dev.azure.com/dnceng/public/_build/results?buildId=1831349&view=ms.vss-test-web.build-test-results-tab).

CC. @eduardo-vp

Author: tannergooding
Assignees: -
Labels:

area-System.Threading, untriaged

Milestone: -

@stefan-sf-ibm
Copy link
Contributor

Did a rebase today and can confirm that ThreadPoolMinMaxThreadsEventTest passes if #68648 is applied.

@uweigand
Copy link
Contributor

Thanks, @stefan-sf-ibm !

@mangod9
Copy link
Member

mangod9 commented Jul 7, 2022

so this issue can be closed I assume?

@uweigand
Copy link
Contributor

uweigand commented Jul 7, 2022

Yes, our CI is now green again. This issue can be closed.

@mangod9
Copy link
Member

mangod9 commented Jul 7, 2022

Thx!

@mangod9 mangod9 closed this as completed Jul 7, 2022
@ghost ghost removed the untriaged New issue has not been triaged by the area owner label Jul 7, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Aug 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants