Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Wasm][net9] MSBuild EmscriptenVersion is still 3.1.34 #108972

Open
jeromelaban opened this issue Oct 17, 2024 · 4 comments · Fixed by dotnet/emscripten#118
Open

[Wasm][net9] MSBuild EmscriptenVersion is still 3.1.34 #108972

jeromelaban opened this issue Oct 17, 2024 · 4 comments · Fixed by dotnet/emscripten#118
Assignees
@radekdoulik
Labels
arch-wasm WebAssembly architecture area-Build-mono
Milestone
9.0.x

Comments

@jeromelaban
Copy link
Contributor

Description

When building with net9 for wasm, the reported emscripten version is 3.1.34 and should be 3.1.56 as the emscripten runtime pack mentions:

CompilerBinaryPath = /github/home/.dotnet/packs/Microsoft.NET.Runtime.Emscripten.3.1.56.Sdk.linux-x64/9.0.0-rc.2.24468.8/Sdk/../tools/emscripten/emcc

Reproduction Steps

Build a wasm app with .NET 9 RC2

Expected behavior

EmscriptenVersion is 3.1.56

Actual behavior

EmscriptenVersion is 3.1.34

Regression?

No.

Known Workarounds

Parsing the path in WasmClang to get the proper version.

Configuration

No response

Other information

No response
@dotnet-policy-service dotnet-policy-service bot added the untriaged New issue has not been triaged by the area owner label Oct 17, 2024
@jeromelaban jeromelaban mentioned this issue Oct 23, 2024
Merged
@lewing lewing added this to the 9.0.0 milestone Oct 23, 2024
@dotnet-policy-service dotnet-policy-service bot removed the untriaged New issue has not been triaged by the area owner label Oct 23, 2024
@lewing
Copy link
Member

lewing commented Oct 23, 2024

we'll have to fix this in servicing

@mergify mergify bot mentioned this issue Oct 23, 2024
Merged
@lewing
Copy link
Member

lewing commented Nov 4, 2024

@radekdoulik ptal

@lewing lewing added the arch-wasm WebAssembly architecture label Nov 4, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

@Numpsy Numpsy mentioned this issue Nov 15, 2024
Open
@radekdoulik radekdoulik mentioned this issue Nov 20, 2024
Merged
@akoeplinger
Copy link
Member

Reopening to track backport.

@akoeplinger akoeplinger reopened this Nov 21, 2024
@lewing lewing modified the milestones: 9.0.0, 9.0.x Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@radekdoulik radekdoulik

Labels
arch-wasm WebAssembly architecture area-Build-mono
Projects
None yet
Milestone
9.0.x
Development

Successfully merging a pull request may close this issue.

Generate emscripten-version.txt file radekdoulik/emscripten
4 participants
@lewing @akoeplinger @radekdoulik @jeromelaban