Go To Definition - f12 fails, tooltip works

[isaacabraham]

If you F12 on a symbol in another file, it can't navigate to the item. However, if you click the type in the tooltip that follows, it works.

[realvictorprm]

I already experienced that in a Fable project with 15.7 .

In 15.8 it still doesn't work there but it works for me on a backend project so looks like it's bound to specific circumstances?

[cartermp]

@isaacabraham can you provide some more details or upload a repro solution?

Using 15.8, .NET Core project:

fsx-to-fs in a .NET Framework project:

[cartermp]

@isaacabraham Do you have a repro? I used this throughout the VF# codebase yesterday and could not get GTD to fail.

[isaacabraham]

I've managed to get a repro in an existing project. The only thing I can see that might be the cause is that the symbol I'm trying to go to definition on lives in a linked .fs file in the project, rather than a normal project file.

[isaacabraham]

I can also reproduce on a script where I'm loading in an .fs file and trying to go to definition of a symbol defined in that. It works if I click on the symbol link in the tooltip, but not with F12.

[0x53A]

I've seen the same in safe bookstore - f12 mostly doesn't work, the clickable tooltips do

[cartermp]

@isaacabraham in the second GIF, I'm doing the same as this:

I can also reproduce on a script where I'm loading in an .fs file and trying to go to definition of a symbol defined in that.

But it succeeds. Do you have a repro?

I'll take a look at the fable bookstore, which uses linked files.

[isaacabraham]

@cartermp this is then something either environmental - my install of 15.8.1 is somehow borked, or something specific with the project. But I can't see anything there else unusual - it's a netcore2.0 console app.

There's definitely something different in the behaviour of Go To Definition when hitting F12 compared to clicking the hyperlink in the tooltip, because the latter works whilst F12 doesn't.

[vasily-kirichenko]

@isaacabraham The implementation of go to def and links on the tooltip are completely different (and surprisingly complicated).

[cartermp]

@isaacabraham I just tried with a .NET Core 2.1 console app with a script that navigates to a symbol in a source file for that project: works with f12, ctrl+click, and tooltip go to definition.

[forki]

So zip with repro it is. Like always...

[cartermp]

Okay, so the issue is when you attempt to go to definition from one linked file to another. Example:

Home.fs --> viewLink symbol

Tooltip shows and you can go to definition, but cannot use f12 or ctrl+click (which share the same implementation).

If files are "normal", or you're going to definition within a linked file, or going to definition between linked/non-linked files, everything seems to work.

I also noticed that finding symbols for Find Refs or Rename is inconsistent in this project. For example:

Wishlist/Msg:

Not a linked file, and the references live in the same file.

Database/DatabaseType:

Not a linked file, and all references live in the same file.

Bug: #5545

[cartermp]

@isaacabraham can you update the title to accurate reflect that this is between linked files?

[isaacabraham]

@cartermp I said that the project contained a link file. I don't believe that all of the issues I'm seeing are only related to symbols that live in that linked file. I'll double check this later today.

[cartermp]

My observations are on playing around with the Bookstore app myself. If you can upload a repro that isn't Go to Definition from a linked file to a linked file, I'd appreciate that.

[isaacabraham]

@cartermp I think the latest version of master in the Azure Storage TP has this issue now (at least, I'm seeing it there).

[cartermp]

Do you have a specific repro there? What I noticed in SAFE was specifically when moving from linked file -> linked file. Is that the same in the Azure Storage TP codebase?

[isaacabraham]

@cartermp I don't believe that there are any linked files in there. It seems to happen when going to definition of a symbol in another file e.g. In AzureTypeProvider.fs, line 69 - try to F12 on Table.StaticSchema.createSchema.

[isaacabraham]

I can confirm that this problem still exists in the latest master of the Azure Storage TP.

[cartermp]

Noting this in two additional areas:

• Tachyus' solution after a chat with them
• Our own codebase, when going from FSharp.Editor --> FSharp.Compiler.Private

[zanaptak]

In the Azure TP it's the forward slashes #4016

[cartermp]

Fixed by #7376