Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker images should point to mcr.microsoft instead of hub.docker #9454

Closed
OwnageIsMagic opened this issue Aug 13, 2024 · 9 comments · Fixed by #9468
Closed

Docker images should point to mcr.microsoft instead of hub.docker #9454

OwnageIsMagic opened this issue Aug 13, 2024 · 9 comments · Fixed by #9468
Assignees

Comments

@OwnageIsMagic
Copy link

OwnageIsMagic commented Aug 13, 2024

URL(s)

* [dotnet/sdk](https://hub.docker.com/_/microsoft-dotnet-sdk/): .NET SDK
* [dotnet/aspnet](https://hub.docker.com/_/microsoft-dotnet-aspnet/): ASP.NET Core Runtime
* [dotnet/runtime](https://hub.docker.com/_/microsoft-dotnet-runtime/): .NET Runtime
* [dotnet/runtime-deps](https://hub.docker.com/_/microsoft-dotnet-runtime-deps/): .NET Runtime Dependencies
* [dotnet/monitor](https://hub.docker.com/_/microsoft-dotnet-monitor/): .NET Monitor
* [dotnet/monitor/base](https://hub.docker.com/_/microsoft-dotnet-monitor-base/): .NET Monitor Base
* [dotnet/samples](https://hub.docker.com/_/microsoft-dotnet-samples/): .NET Samples

This also applies to previous .net versions

Description

@mairaw
Copy link
Contributor

mairaw commented Aug 15, 2024

I was planning to change them to this format instead: https://hub.docker.com/r/microsoft/dotnet-sdk/

@lbussell any comments on this?

@lbussell
Copy link
Contributor

@mairaw the content on DockerHub is mostly static at this point. MAR at least has tag listings, e.g. https://mcr.microsoft.com/product/dotnet/sdk/tags. I am in favor of switching links to MAR. The link format would be https://mcr.microsoft.com/product/dotnet/sdk/.

/cc @richlander @MichaelSimons @mthalman

@MichaelSimons
Copy link
Member

I don't like any of the options currently available. MAR has had some terrible delays in updating the tags table which provides a bad UX. The general UX of the tags table is poor. IMO the best tags browsing experience is the tags table in the GH readmes. Our GH repos still point to DH as the preferred portal because of the poor MAR UX. We should be consistent IMO.

@lbussell
Copy link
Contributor

IMO the best tags browsing experience is the tags table in the [GitHub] readmes.

Agree

Our [GitHub] repos still point to DH as the preferred portal because of the poor MAR UX.

This was decided long before the reduced character limit on DockerHub forced us to remove the tags tables there. I think that MAR having any tags listing at all gives it a better user experience than DockerHub today (for .NET repos). Plus we (Microsoft) own MAR. I feel like the decision should be between MAR/GitHub.

@mthalman
Copy link
Member

I vote for the links to point to the GitHub repo.

@MichaelSimons
Copy link
Member

I am onboard with GitHub links. Once the MAR portal is improved, we can switch to it.

@lbussell
Copy link
Contributor

@mairaw
Copy link
Contributor

mairaw commented Aug 16, 2024

Ok, thanks all! I can help with the updates.

@mairaw mairaw self-assigned this Aug 16, 2024
@mairaw
Copy link
Contributor

mairaw commented Aug 16, 2024

PR created. I kept the https://hub.docker.com/_/microsoft-dotnet links.

There were also links in the format https://hub.docker.com/_/microsoft-dotnet-core-runtime/ (with core in the url) that I applied the same logic. But did it in a separate commit in case my assumption was wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants