Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SignTool should not attempt to sign 0 length files #15001

Closed
2 tasks
Tracked by #3708
mmitche opened this issue Aug 14, 2024 · 3 comments
Closed
2 tasks
Tracked by #3708

SignTool should not attempt to sign 0 length files #15001

mmitche opened this issue Aug 14, 2024 · 3 comments
Assignees

Comments

@mmitche
Copy link
Member

mmitche commented Aug 14, 2024

  • This issue is blocking
  • This issue is causing unreasonable pain

0 length files exist in some cases (e.g. python packages). We should not attempt to sign any of these.

@missymessa
Copy link
Member

@ellahathaway do you know which epic this should go in? We're thinking VMR, but not sure.

@ellahathaway
Copy link
Member

Yes, I'll add it to the correct epic and project!

@ellahathaway
Copy link
Member

T-Shirt Size: XS

I think that this is as simple as checking the size of the file when it gets passed to the configuration class as an item to sign & skipping it if it's 0.

@mmitche mmitche self-assigned this Dec 9, 2024
@mmitche mmitche moved this to In Progress in .NET Unified Build Dec 9, 2024
@mmitche mmitche closed this as completed Dec 10, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in .NET Unified Build Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

3 participants