Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider switching to a smaller ZIP library #742

Closed
101arrowz opened this issue Jan 1, 2021 · 3 comments
Closed

Consider switching to a smaller ZIP library #742

101arrowz opened this issue Jan 1, 2021 · 3 comments

Comments

@101arrowz
Copy link

Over the past few months, I've developed fflate. It's a ZIP library that would replace JSZip, but it's much faster and an order of magnitude smaller. You can check the demo and see the benchmarks within the library to see this for yourself. Let me know if you'd be interested in switching, and I'll draft a PR.

@dolanmiu
Copy link
Owner

dolanmiu commented Jan 1, 2021

Does it work on node and on the browser?

Edit: found out it does, nice

I am unsure about the switch though JSZip is mature and battle tested, whereas fflate seems a bit new

@101arrowz
Copy link
Author

Yes, that is true, it's quite a new library. But many major projects have already switched, and I usually fix issues within a day.

ZIP compression is the most well-tested function in the library, and I haven't gotten any bugs related to it yet. ZIP decompression has had a few issues, but they weren't too hard to fix.

@dolanmiu
Copy link
Owner

I will re-open if in the future if need be. But at the moment, it's a no for now

Thanks very much for your contribution though to this lib and open source in general though, I appreciate it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants