Looked at contributing to get on 2023.3, starting to understand some of your pain I think.. #740
svengeance
started this conversation in
General
Replies: 2 comments 2 replies
-
Hey! |
Beta Was this translation helpful? Give feedback.
1 reply
-
any updates i really need this theme on 2023.3 version. |
Beta Was this translation helpful? Give feedback.
1 reply
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Hey fam, wanted to get in contact, decided this was better than hitting up the Contact section on your website.
So.....I cloned a few of your repos, set some GH tokens, and trying to build: looks like there was a major change with the way SVGs are loaded in 2023. Tracing down the code, they moved to JSVG loading and fucked with some of the internal interfaces being used resulting in some breakages, some of which are..
SvgElementColorPatcherProvider.attributeForPath
now returns anSvgAttributePatcher
SvgElementColorPatcherProvider
now needs to implement its own digest/hash..SvgAttributePatcher
operates on aMutableMap<string, string>
than an svgAm I on the right track with 2023.3 support? I don't know what the hell I'll run into after this, but.. /shrug
Would love to hear from you, short of that I might try to continue a bit getting doki-theme-icons-jetbrains to compile again.
Beta Was this translation helpful? Give feedback.
All reactions