Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cannot read property 'classList' of null #1527

Merged
merged 4 commits into from
Mar 12, 2021

Conversation

sy-records
Copy link
Member

Summary

What kind of change does this PR introduce? (check at least one)

fix #1526

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Docs
  • Build-related changes
  • Repo settings
  • Other, please describe:

If changing the UI of default theme, please provide the before/after screenshot:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)

You have tested in the following browsers: (Providing a detailed version will be better.)

  • Chrome
  • Firefox
  • Safari
  • Edge
  • IE

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature
  • Related documents have been updated
  • Related tests have been updated

To avoid wasting your time, it's best to open a feature request issue first and wait for approval before working on it.

@vercel
Copy link

vercel bot commented Mar 8, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/docsify-core/docsify-preview/9Vdd11qnt2MfHT6jzGGKz6oQLFC6
✅ Preview: https://docsify-preview-git-fork-sy-records-fix-1526-docsify-core.vercel.app

@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 8, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 85863b3:

Sandbox Source
docsify-template Configuration

Koooooo-7
Koooooo-7 previously approved these changes Mar 9, 2021
Copy link
Member

@Koooooo-7 Koooooo-7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@trusktr
Copy link
Member

trusktr commented Mar 9, 2021

Why does this error happen? It could indicate some other issue.

Different topic: I think the issue template is fairly useless. Most PRs lately have no description (which isn't good), and the rest of the template is usually just noise.

trusktr
trusktr previously approved these changes Mar 9, 2021
@sy-records
Copy link
Member Author

sy-records commented Mar 9, 2021

Why does this error happen? It could indicate some other issue.

The problem exists under IE11, I'm not quite sure of the exact cause

Edit: Or maybe it's a problem with the theme he's using...

Different topic: I think the issue template is fairly useless. Most PRs lately have no description (which isn't good), and the rest of the template is usually just noise.

Yes, many do not follow the issue template to ask questions.

@sy-records
Copy link
Member Author

image

I have reproduced the problem.

without setting name.
Set hideOtherSidebarContent in search.

- name: 'docsify',
  search: {
+    hideOtherSidebarContent: true,
  },

@sy-records sy-records merged commit d6df2b8 into docsifyjs:develop Mar 12, 2021
@sy-records sy-records deleted the fix-1526 branch March 12, 2021 00:48
trusktr added a commit that referenced this pull request May 4, 2021
* develop: (104 commits)
  chore: bump ssri from 6.0.1 to 6.0.2 (#1563)
  chore: Update Edit Document using develop branch (#1541)
  fix: Add escapeHtml for search (#1551)
  docs: link with plugin Pagination (#1554)
  fix: Upgrade dompurify from 2.2.6 to 2.2.7 (#1553)
  fix: upgrade dompurify from 2.2.6 to 2.2.7 (#1552)
  chore: bump y18n from 4.0.0 to 4.0.1 (#1548)
  chore: Fix search for missing pathNamespaces (#1547)
  fix: Upgrade docsify from 4.12.0 to 4.12.1 (#1544)
  docs:Update deploy, change Zeit to Vercel (#1540)
  fix: Cannot read property 'classList' of null (#1527)
  chore: fix microsoft/playwright-github-action error (#1534)
  Update PULL_REQUEST_TEMPLATE.md
  chore: Update CHANGELOG and Update test snapshots
  chore: add changelog 4.12.1
  [build] 4.12.1
  feat: Support search when there is no title (#1519)
  test(unit): add test cases on isExternal. (#1515)
  docs: Update Vercel logo link (#1520)
  fix: Upgrade docsify from 4.11.6 to 4.12.0 (#1518)
  ...
@Koooooo-7 Koooooo-7 mentioned this pull request Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search is KO with IE11
4 participants