Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[27.x backport] cli/command/system: remove netfilter warnings from tests #5692

Merged

Conversation

thaJeztah
Copy link
Member

These warnings will no longer be returned by the daemon, so remove them from the tests as well to make them more representative of reality.

(cherry picked from commit 55e404e)

These warnings will no longer be returned by the daemon, so remove
them from the tests as well to make them more representative of
reality.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
(cherry picked from commit 55e404e)
Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added status/2-code-review area/testing kind/refactor PR's that refactor, or clean-up code labels Dec 13, 2024
@thaJeztah thaJeztah added this to the 27.4.1 milestone Dec 13, 2024
@thaJeztah thaJeztah self-assigned this Dec 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.58%. Comparing base (6377f54) to head (70815c1).
Report is 3 commits behind head on 27.x.

Additional details and impacted files
@@           Coverage Diff           @@
##             27.x    #5692   +/-   ##
=======================================
  Coverage   58.58%   58.58%           
=======================================
  Files         346      346           
  Lines       29320    29320           
=======================================
  Hits        17176    17176           
  Misses      11171    11171           
  Partials      973      973           

Copy link
Member

@laurazard laurazard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit fce7c04 into docker:27.x Dec 13, 2024
102 checks passed
@thaJeztah thaJeztah deleted the 27.x_backport_remove_netfilter_warnings branch December 13, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing kind/refactor PR's that refactor, or clean-up code status/2-code-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants