Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Chrome _initiator block #9

Open
dnnrly opened this issue May 15, 2021 · 3 comments
Open

Add support for Chrome _initiator block #9

dnnrly opened this issue May 15, 2021 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@dnnrly
Copy link
Owner

dnnrly commented May 15, 2021

Is your feature request related to a problem? Please describe.
Chrome has additional _initiator block. This seems to include information about what has invoked each network fall.

Describe the solution you'd like
It would be great if we could see which scripts or user events initiate network calls in our diagrams

Describe alternatives you've considered
Nothing yet. This appears to be specific to Chrome but this information might be present in other browsers

Additional context
n/a

@dnnrly dnnrly added the help wanted Extra attention is needed label May 15, 2021
@DBX12
Copy link
Contributor

DBX12 commented Oct 23, 2022

HI @dnnrly,
hoofli sounds like an interesting project and I would like to help out here. I'll hand in a pull request shortly. Do you have an idea how you want to show the _initator on the diagram? I think the most interesting part is the type property of the _initiator object since it shows who started the request. The other parameters are probably interesting as well, but will clutter the diagram. Maybe they can be shown when a certain flag is provided to hoofli?
For the type, I think I would go with different colors for the different types. I could identify the values script, parser and other so far.

@dnnrly
Copy link
Owner Author

dnnrly commented Oct 23, 2022

I don't really have a strong opinion as long as it makes it clear what's going on. Why don't you have a try and if you're not sure then propose some options.

@DBX12
Copy link
Contributor

DBX12 commented Oct 23, 2022

I think the color-coding does a good job and showing what caused a request. I've put it up as PR so you can have a look :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants