Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed api paths #109

Merged
merged 4 commits into from
Jan 27, 2020
Merged

Fixed api paths #109

merged 4 commits into from
Jan 27, 2020

Conversation

pavelhouzva
Copy link
Contributor

@dirkgroenen
Copy link
Owner

I'll take a look at this as soon as I get back from my holidays, next week.

@pavelhouzva
Copy link
Contributor Author

pavelhouzva commented Jan 21, 2020 •
edited
Loading

Pinterest API requires "/" at the end of every path.
API redirects with 308 HTTP code which is not handled in CurlBuilder.
(#110 )

API call: https://api.pinterest.com/v1/me/boards

Response headers:
0:                               	HTTP/2 308 
content-type:                           text/html; charset=utf-8
content-length:                         285
location:                               https://api.pinterest.com/v1/me/boards/
pinterest-generated-by:                 coreapp-ngapi-prod-0a018332
x-envoy-upstream-service-time:          5
cache-control:                          private
date:                            	Tue, 21 Jan 2020 12:35:28 GMT
set-cookie:                             _ir=0; Max-Age=1800; HttpOnly; Path=/; Secure
x-cdn:                           	akamai
age:                             	0


Reponse body:
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">
<title>Redirecting...</title>
<h1>Redirecting...</h1>
<p>You should be redirected automatically to target URL: <a href="https://api.pinterest.com/v1/me/boards/">https://api.pinterest.com/v1/me/boards/</a>.  If not click the link.array(0) {
}

@dirkgroenen dirkgroenen merged commit de5e545 into dirkgroenen:master Jan 27, 2020
@dirkgroenen
Copy link
Owner

Thanks @pavelhouzva.
These changes have been released as 0.2.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pavelhouzva @dirkgroenen