Use of peerDependencies for vow breaks shrinkwrapping of packages using this lib

[cvrebert]

$ cat package.json  # Note: csscomb depends on vow-fs (& thus vow-queue)

{
  "name": "foobar",
  "private": true,
  "devDependencies": {
    "csscomb": "^2.0.4"
  }
}

$ npm install
<succeeds>
$ npm ls
foobar@ /Users/chris.rebert/code/foobar
└─┬ [email protected]
  ├── [email protected]
  ├── [email protected]
  ├─┬ [email protected]
  │ ├── [email protected]
  │ └── [email protected]
  ├── [email protected]
  └─┬ [email protected]
    ├── [email protected]
    └─┬ [email protected]
      └── UNMET DEPENDENCY vow ~0.3.9

npm ERR! missing: vow@~0.3.9, required by [email protected]
npm ERR! not ok code 0
$ npm shrinkwrap
npm ERR! Error: Problems were encountered
npm ERR! Please correct and try again.
npm ERR! missing: vow@~0.3.9, required by [email protected]
npm ERR!     at shrinkwrap_ (/usr/local/share/npm/lib/node_modules/npm/lib/shrinkwrap.js:30:15)
npm ERR!     at /usr/local/share/npm/lib/node_modules/npm/lib/shrinkwrap.js:24:5
npm ERR!     at /usr/local/share/npm/lib/node_modules/npm/lib/ls.js:44:30
npm ERR!     at /usr/local/share/npm/lib/node_modules/npm/node_modules/read-installed/read-installed.js:130:5
npm ERR!     at /usr/local/share/npm/lib/node_modules/npm/node_modules/read-installed/read-installed.js:258:14
npm ERR!     at cb (/usr/local/share/npm/lib/node_modules/npm/node_modules/slide/lib/async-map.js:48:11)
npm ERR!     at /usr/local/share/npm/lib/node_modules/npm/node_modules/read-installed/read-installed.js:258:14
npm ERR!     at cb (/usr/local/share/npm/lib/node_modules/npm/node_modules/slide/lib/async-map.js:48:11)
npm ERR!     at /usr/local/share/npm/lib/node_modules/npm/node_modules/read-installed/read-installed.js:258:14
npm ERR!     at cb (/usr/local/share/npm/lib/node_modules/npm/node_modules/slide/lib/async-map.js:48:11)
npm ERR! If you need help, you may report this *entire* log,
npm ERR! including the npm and node versions, at:
npm ERR!     <http://github.com/npm/npm/issues>

npm ERR! System Darwin 13.1.0
npm ERR! command "node" "/usr/local/bin/npm" "shrinkwrap"
npm ERR! cwd /Users/chris.rebert/code/foobar
npm ERR! node -v v0.10.26
npm ERR! npm -v 1.4.9
npm ERR! 
npm ERR! Additional logging details can be found in:
npm ERR!     /Users/chris.rebert/code/foobar/npm-debug.log
npm ERR! not ok code 0

[dfilatov]

I don't understand why "missing: vow@~0.3.9, required by [email protected]".
[email protected] which was installed earlier, must satisfy that condition.

[cvrebert]

I think because vow-fs and vow-queue are at different levels in the tree, thus they don't share siblings?

Also, the npm folks are debating deprecating the peerDependencies feature: npm/npm#5080

[XhmikosR]

Ping

[pwmckenna]

👍

[vladikoff]

Why is this issue happening? Was this a breaking change in NPM?

[cvrebert]

Sort of. Until recently, npm didn't error out in such situations; now it does.

[josegonzalez]

Well this is still broken, does anyone know of a workaround? It totally breaks listing the npm cache as well, which does wonders for my sanity.

[pwmckenna]

you can just downgrade npm to 1.4.0 or so. not ideal, but saved me big time.

[vladikoff]

I had to downgrade to 1.3
On May 30, 2014 2:08 PM, "Patrick Williams" [email protected]
wrote:

you can just downgrade npm to 1.4.0 or so. not ideal, but saved me big
time.

—
Reply to this email directly or view it on GitHub
#10 (comment).

[cvrebert]

@dfilatov So, any chance of either removing peerDependencies from vow or commenting on npm/npm#5080 ?

[dfilatov]

@cvrebert I've released vow-queue 0.3.1 without peerDependencies from vow. Is it enough?

[cvrebert]

@dfilatov That helps, but:

• Latest vow-fs still depends on [email protected]
• Latest csscomb.js still depends on [email protected] (This one might understandably be out of your control.)

[XhmikosR]

For csscomb I guess we'll have to bug the csscomb guys after the vow(*) stuff is fixed.

[tonyganch]

Hi, guys.
Let's discuss all CSScomb related stuff here: csscomb/csscomb.js#229

[dfilatov]

@cvrebert I've released [email protected] which has no more peerDependencies from vow.

[cvrebert]

Thanks again!