Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new icon: gitkraken (original, original-wordmark, plain, plain-wordmark) #2280

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

boterop
Copy link

@boterop boterop commented Oct 7, 2024

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes #1455

Link to prove your SVG is correct and up-to-date.

https://www.gitkraken.com/

Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

1 similar comment
Copy link
Contributor

Hi!

I'm the check-bot and we have some issues with your PR:

devicon.json is not sorted correctly.
Please make sure that your icon is added in the `devicon.json` file at the correct alphabetic position
as seen here: https://github.com/devicons/devicon/wiki/Updating-%60devicon.json%60


Check our CONTRIBUTING guide for more details regarding these errors.

Please address these issues. When you update this PR, I will check your SVGs again.

Thanks for your help,
SVG-Checker Bot 😄

canaleal
canaleal previously approved these changes Oct 14, 2024
Copy link
Member

@canaleal canaleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 💯

I optimized the SVGs using SVGOMG and checked them with IcoMoon for any artifacts.

Additionally, since the original SVG contains only one path and fill color, it can also serve as an alias for the plain SVG.

@canaleal canaleal requested review from a team, ConX, weh, Snailedlt and lunatic-fox and removed request for a team October 14, 2024 01:01
Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor changes, the rest looks good 👍

icons/gitkraken/gitkraken-original-wordmark.svg Outdated Show resolved Hide resolved
icons/gitkraken/gitkraken-plain-wordmark.svg Outdated Show resolved Hide resolved
icons/gitkraken/gitkraken-original.svg Outdated Show resolved Hide resolved
@boterop boterop requested review from weh and canaleal October 15, 2024 13:47
@canaleal canaleal added the feature:icon Use this label for pull requests when a new icon is ready to be added to the collection label Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:icon Use this label for pull requests when a new icon is ready to be added to the collection
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants