Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deactivate Quarkus telemetry causing stacktrace #443

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

apupier
Copy link
Contributor

@apupier apupier commented Jul 5, 2024

Users won't have the possibility to answer to the question and we need to keep it opt-in

fixes devfile/api#1611

What does this PR do?:

Summarize the changes. Are any stacks or samples added or updated?

Which issue(s) this PR fixes:

Link to github issue(s)

PR acceptance criteria:

  • Contributing guide
    Have you read the devfile registry contributing guide and followed its instructions?
  • Test automation
    Does this repository's tests pass with your changes?
  • Documentation
    Does any documentation need to be updated with your changes?
  • Check Tools Provider
    Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)

How to test changes / Special notes to the reviewer:

@apupier apupier requested review from maxandersen and a team as code owners July 5, 2024 08:24
@openshift-ci openshift-ci bot requested review from johnmcollier and thepetk July 5, 2024 08:24
Copy link

openshift-ci bot commented Jul 5, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: apupier
Once this PR has been reviewed and has the lgtm label, please assign elsony for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented Jul 5, 2024

Hi @apupier. Thanks for your PR.

I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

@thepetk thepetk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs review from @maxandersen as the stack owner

@maxandersen
Copy link
Collaborator

On pto but was the original issue reported somewhere as user should not get an error for this.

@apupier
Copy link
Contributor Author

apupier commented Jul 23, 2024

On pto but was the original issue reported somewhere as user should not get an error for this.

reported quarkusio/quarkus#42058

Given that i wasn't reproducing outside of the devfile context I wasn't sure where is the root issue.

Users won't have the possibility to answer to the question and we need
to keep it opt-in

fixes devfile/api#1611

Signed-off-by: Aurélien Pupier <[email protected]>
@apupier apupier force-pushed the 1611-deactivateQuarkusTelemetryToAvoidStackTrace branch from 645db46 to 09f7578 Compare July 24, 2024 13:29
Copy link
Contributor

@Jdubrick Jdubrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

Copy link
Collaborator

@maxandersen maxandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a fan as fix happening and will make it not be so noisy.

afaik this is only issue in che for some reason it doesn't handle terminal/tty?

@apupier
Copy link
Contributor Author

apupier commented Aug 5, 2024

not a fan as fix happening and will make it not be so noisy.

If I understand well the fix, it will remain this message in log:

tools: ----------------------------
tools: --- Help improve Quarkus ---
tools: ----------------------------
tools: * Learn more: https://quarkus.io/usage/
tools: * Do you agree to contribute anonymous build time data to the Quarkus community? (y/n and enter) 
tools: [info] [Quarkus build analytics] Didn't receive a valid user's answer: `y` or `n`. The question will be asked again next time.

I feel like this will be nicer anyway to not have a this kind of log. It will also avoid to raise an exception which should gain few milliseconds.

afaik this is only issue in che for some reason it doesn't handle terminal/tty?

It is not only in Che context. Currently, it is when using odo and deploy on an OpenShift instance. Hich is something that can be used from local command-line, VS Code OpenShift toolkit, IntelliJ OpenShift extension; both locally or inside Che.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error logged with Quarkus stacks related to telemetry usage
5 participants