-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deactivate Quarkus telemetry causing stacktrace #443
base: main
Are you sure you want to change the base?
Deactivate Quarkus telemetry causing stacktrace #443
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: apupier The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @apupier. Thanks for your PR. I'm waiting for a devfile member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs review from @maxandersen as the stack owner
On pto but was the original issue reported somewhere as user should not get an error for this. |
reported quarkusio/quarkus#42058 Given that i wasn't reproducing outside of the devfile context I wasn't sure where is the root issue. |
Users won't have the possibility to answer to the question and we need to keep it opt-in fixes devfile/api#1611 Signed-off-by: Aurélien Pupier <[email protected]>
645db46
to
09f7578
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not a fan as fix happening and will make it not be so noisy.
afaik this is only issue in che for some reason it doesn't handle terminal/tty?
If I understand well the fix, it will remain this message in log:
I feel like this will be nicer anyway to not have a this kind of log. It will also avoid to raise an exception which should gain few milliseconds.
It is not only in Che context. Currently, it is when using odo and deploy on an OpenShift instance. Hich is something that can be used from local command-line, VS Code OpenShift toolkit, IntelliJ OpenShift extension; both locally or inside Che. |
Users won't have the possibility to answer to the question and we need to keep it opt-in
fixes devfile/api#1611
What does this PR do?:
Summarize the changes. Are any stacks or samples added or updated?
Which issue(s) this PR fixes:
Link to github issue(s)
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: