WIP: Update ci operator scripts to set architecture #419
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jdubrick, michael-valdron The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
FYI going to leave this unmerged until I have a PR open for the ci-operator and then merge them together. The |
/hold |
Expected failure - This is why PR is being held. |
|
New changes are detected. LGTM label has been removed. |
|
@michael-valdron I had to swap the |
Jdubrick
changed the title
.ci/openshift_integration.sh
Outdated
| if [ ! -z "$1" ] | ||
| then | ||
| arch="$1" | ||
| else | ||
| arch="$DEFAULT_ARCH" | ||
| fi |
There was a problem hiding this comment.
This might fix the error being thrown:
| if [ ! -z "$1" ] | |
| then | |
| arch="$1" | |
| else | |
| arch="$DEFAULT_ARCH" | |
| fi | |
| if [ $# -gt 0 ] | |
| then | |
| arch="$1" | |
| else | |
| arch="$DEFAULT_ARCH" | |
| fi |
|
/retest |
|
@Jdubrick: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Signed-off-by: Jordan Dubrick <[email protected]>
Jdubrick
force-pushed
the
feat/update-ci-for-arm64
branch
from
5493436 to
56df475
Compare
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What does this PR do?:
Summarize the changes. Are any stacks or samples added or updated?
This allows for an optional argument to be passed alongside the script to allow for the proper binaries to be downloaded for
odoandyq.Which issue(s) this PR fixes:
Link to github issue(s)
fixes devfile/api#1594
PR acceptance criteria:
Have you read the devfile registry contributing guide and followed its instructions?
Does this repository's tests pass with your changes?
Does any documentation need to be updated with your changes?
Have you tested the changes with existing tools, i.e. Odo, Che, Console? (See devfile registry contributing guide on how to test changes)
How to test changes / Special notes to the reviewer: