Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double validation when saving profile #548

Closed
leobragaz opened this issue Jul 8, 2021 · 0 comments · Fixed by #557
Closed

Double validation when saving profile #548

leobragaz opened this issue Jul 8, 2021 · 0 comments · Fixed by #557
Assignees
Labels
kind/bug Something isn't working x/profiles Module that allows to create and manage decentralized social profiles
Milestone

Comments

@leobragaz
Copy link
Contributor

Inside the SaveProfile function of msg_server_profile.go we validate the profile twice:

  1. Inside the Update function;
  2. Another time inside keeper's ValidateProfile();

I think the validation could be removed from within the Update() function and left only inside the keeper's Validate()
function since Update() is only used once.

@leobragaz leobragaz added kind/bug Something isn't working x/profiles Module that allows to create and manage decentralized social profiles labels Jul 8, 2021
@leobragaz leobragaz self-assigned this Jul 12, 2021
@RiccardoM RiccardoM added this to the v1.0.0 milestone Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working x/profiles Module that allows to create and manage decentralized social profiles
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants