Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doubt about the defined hinge version Loss #34

Open
hhguo opened this issue Sep 10, 2020 · 2 comments
Open

Doubt about the defined hinge version Loss #34

hhguo opened this issue Sep 10, 2020 · 2 comments

Comments

@hhguo
Copy link

hhguo commented Sep 10, 2020

Hi, I am curious about the hinge loss defined in your paper. It seems that your implementation is different.

This is the definition in your paper.
image

But you use F.relu in the code, which is max(0, D(x))
image

I tend to believe that the code implementation is correct, so maybe the paper definition is wrong?

@allenhung1025
Copy link

I have the same doubt, too.

@jamesliu
Copy link

jamesliu commented Nov 28, 2020

I believe the implementation is right, but the paper definition is likely not correct(max instead of min or adding -). May someone confirm it? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants