Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amina/ redirection from deriv-app to Accounts OS application for POI submission #17779

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

amina-deriv
Copy link
Contributor

Changes:

Please provide a summary of the change.

Screenshots:

Please provide some screenshots of the change.

Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
deriv-app ❌ Failed (Inspect) Dec 25, 2024 1:02pm

@coveralls
Copy link

coveralls commented Dec 9, 2024

Pull Request Test Coverage Report for Build 12493038521

Details

  • 14 of 36 (38.89%) changed or added relevant lines in 3 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 53.876%

Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/account/src/Constants/routes-config.tsx 3 5 60.0%
packages/account/src/Sections/Verification/ProofOfIdentity/proof-of-identity-flow.tsx 8 28 28.57%
Files with Coverage Reduction New Missed Lines %
packages/trader/src/AppV2/Utils/trade-params-utils.tsx 2 86.4%
Totals Coverage Status
Change from base Build 12481315103: -0.01%
Covered Lines: 33052
Relevant Lines: 57174

💛 - Coveralls

Copy link
Contributor

github-actions bot commented Dec 9, 2024

A production App ID was automatically generated for this PR. (log)

Click here to copy & paste above information.
- **PR**: [https://github.com/deriv-com/deriv-app/pull/17779](https://github.com/deriv-com/deriv-app/pull/17779)
- **URLs**:
    - **w/ App ID + Server**: https://deriv-app-git-fork-amina-deriv-amina-testtradershubworkflow.binary.sx?qa_server=red.derivws.com&app_id=32210
    - **Original**: https://deriv-app-git-fork-amina-deriv-amina-testtradershubworkflow.binary.sx
- **App ID**: `32210`

Copy link
Contributor

github-actions bot commented Dec 9, 2024

🚨 Lighthouse report for the changes in this PR:

Category Score
🔺 Performance 28
🟧 Accessibility 70
🟢 Best practices 92
🟧 SEO 77
🟧 PWA 78

Lighthouse ran with https://deriv-app-git-fork-amina-deriv-amina-testtradershubworkflow.binary.sx/

Copy link
Contributor

@likhith-deriv likhith-deriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add noopener,noreferrer

@amina-deriv amina-deriv changed the title Amina/fix: redirection_test Amina/ redirection from deriv-app to Accounts OS application for POI submission Dec 17, 2024
Copy link
Contributor

github-actions bot commented Dec 25, 2024

Generating Lighthouse report...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants