-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for disabling top-scroll for partials #1923
Comments
This is a perfect use case for partials. Agree that we should have a way to disable the "scroll to top" feature. |
FWIW: As a workaround for now you could use a |
Ohh, interesting. Thanks for the suggestion! I read through the partials documentation, but did not realize you can use other than links. I think this part, and the fact all examples use
But I see now that I missed this part:
So I guess using on |
Forms are a bit unfinished yet, but plan is to make them work with partials too. Also good point on the documentation not mentioning button really |
Closing as form support landed with #1930 |
The new Partials feature looks really nice so far. Though, when I did a quick test with updating add-to-cart and the cart status via partials, the top-scroll feature was in the way. Scrolling to top is a great thing to do when the entire main content changes and it's a new "page". But if using partials to replace small areas on the page, it's not as great.
Or is it a use-case that is not intended for partials? In the demo below there are only two small partials, highlighted in red.
Screenshare.-.2023-10-12.4_40_59.PM.mp4
It would be awesome if there was a
f-no-scroll
or similar directive to use. Or perhapsf-client-nav='no-scroll'
. Some way to say "navigations here should not scroll". Still, it looks to me like Partials are really promising so far!The text was updated successfully, but these errors were encountered: