Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(lsp): directly use file referrer when loading document #24997

Merged
merged 3 commits into from
Aug 12, 2024

Conversation

nayeemrmn
Copy link
Collaborator

Fixes #24592.

On this line: https://github.com/denoland/deno/blob/v1.45.5/cli/lsp/documents.rs#L1467, the referrer won't yield the correct file referrer later if it's a remote specifier which isn't directly the key to a document. Passing around file_referrer is the intended solution anyway and seems to work. I don't know how to reproduce this for a test.

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nayeemrmn nayeemrmn merged commit 9bdab6f into denoland:main Aug 12, 2024
17 checks passed
@nayeemrmn nayeemrmn deleted the lsp-doc-load-with-file-referrer branch August 12, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Language server type inference failure after 1.44.0
2 participants