fix(lsp): directly use file referrer when loading document #24997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24592.
On this line: https://github.com/denoland/deno/blob/v1.45.5/cli/lsp/documents.rs#L1467, the
referrer
won't yield the correct file referrer later if it's a remote specifier which isn't directly the key to a document. Passing aroundfile_referrer
is the intended solution anyway and seems to work. I don't know how to reproduce this for a test.