add .css and image file support #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…files from ~/.images Rakefile changed to create ~/.css and ~/.images dirs README.markdown changed to reflect new bonus functionality NOTE! no changes to the extensions were made.
|
This would be awesome. |
|
I like it. What do you think about using |
|
|
|
Sure I'm not concerned about where the files live so long as I can get them into my browser. I'm a lot more worried about how I would make those changes and update this pull request, I'm just a yellow belt in git fu. |
|
I'd like to load CSS files based on domain name just like JS files are loaded. I can provide a pull request that uses ~/.js/css and ~/.js/images AND modifies the Chrome extension to also load CSS files. Should I just submit a different pull request? |
|
I second bartt's preference, I am a big fan of this in the FF port of dotjs. |
|
closing unless someone wants to update the paths |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
djsd changed to also serve .css files from ~/css. and .gif|.jpg|.png files from ~/.images
NOTE! no changes to the extensions were made!
I only added the ability to call http://localhost:3131/arbitrary.css or http://localhost:3131/some-pic.png
and have them resolve from ~/.css and ~/.images
This should allow including .css files from scripts, host icon or badge elements you might be throwing up locally.
I'm conflicted about changing the extension to automatically attempt to load http://localhost:3131/google.com.css seems like it might be a good idea, but i don't know what the performance hit would be.