Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure CI so it doesnt install dependencies and compile the contracts for every step #88

Open
0xteddybear opened this issue Oct 16, 2024 · 0 comments

Comments

@0xteddybear
Copy link
Contributor

0xteddybear commented Oct 16, 2024

the current CI setup

  • configures node
  • installs foundry
  • installs dependencies with yarn
  • and finally builds the project

for every step such as running integration tests, running unit tests, and the various static analysis tools

we could reduce the gh runner time we spend if we only did that setup once (albeit that might reduce paralelism and, for example, omit to run tests if a linter fails)

update: after a quick conversation with @0xGorilla , I understood it was deliberate decision to run the setup multiple times as it was highly desireable for the rest of the checks to

  • run in parallel
  • be independent of each other

so this will be implemented only if we can maintain the two properties above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant