Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMS crashes on rich text formatting option selection #969

Closed
josevh opened this issue Dec 27, 2017 · 3 comments
Closed

CMS crashes on rich text formatting option selection #969

josevh opened this issue Dec 27, 2017 · 3 comments

Comments

@josevh
Copy link

josevh commented Dec 27, 2017

- Do you want to request a feature or report a bug?
bug

- What is the current behavior?
Editor crashes. Message:

Sorry! There's been an error - please report it!

- If the current behavior is a bug, please provide the steps to reproduce.

  1. In /admin, click button for new post
  2. Before typing anything in markdown widget, click H1 twice
    • Also crashes with: H2, and the quote icon with same steps.

- What is the expected behavior?
Affected button should toggle on and off.

- Please mention your CMS, node.js, and operating system version.

  • Netlify CMS: 1.0.3
  • Node v8.9.3 (npm v5.5.1)
  • Firefox: 58.0b12 (64-bit)
  • Chrome: 63.0.3239.84
Netlify CMS version 1.0.3     index.js:20
Error: Invalid `key` argument! It must be a key string, but you passed: null     react-dom.production.min.js:164:440
Stack trace:
o@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:82754
value@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:89536
h/e[t]@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:180037
value@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:95647
value@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:1608228
s@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:710533
beginWork@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:714940
o@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:718856
a@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:719177
l@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:719415
E@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:722949
_@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:722686
batchedUpdates@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:732226
Z@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:693321
Se@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:697215


Error: Invalid `key` argument! It must be a key string, but you passed: null     ErrorBoundary.js:27:4
Stack trace:
o@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:82754
value@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:89536
h/e[t]@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:180037
value@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:95647
value@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:1608228
s@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:710533
beginWork@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:714940
o@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:718856
a@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:719177
l@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:719415
E@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:722949
_@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:722686
batchedUpdates@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:732226
Z@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:693321
Se@https://unpkg.com/netlify-cms@%5E1.0.0/dist/cms.js:1:697215
@josevh josevh changed the title CMS crashes on H1 rich text formatting option selection CMS crashes on rich text formatting option selection Dec 27, 2017
@prateepgedupudi
Copy link

Same for me. I am getting the same error when I click on markdown widget editor.

@tech4him1
Copy link
Contributor

tech4him1 commented Dec 29, 2017

I believe this was fixed in #955, which will be in the next release. Can you try reproducing on the CMS Demo site, since it already has the fix?

@josevh
Copy link
Author

josevh commented Dec 29, 2017

@tech4him1 You're right it is fixed, I cannot reproduce the issue on the demo site. I'll close this.

@josevh josevh closed this as completed Dec 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants