Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handler segfaults itself when using multiple v8 isolates #49

Open
laverdet opened this issue Apr 5, 2018 · 0 comments
Open

Handler segfaults itself when using multiple v8 isolates #49

laverdet opened this issue Apr 5, 2018 · 0 comments

Comments

@laverdet
Copy link

laverdet commented Apr 5, 2018

In segfault-handler.cpp:113 the only check to determine if you're currently in the nodejs isolate is if (Isolate::GetCurrent()) which is not correct in multi-isolate environments (see my project: isolated-vm). So if a segfault is hit while in a different isolate the segfault handler will segfault itself when it tries to call a callback belonging to a different isolate.

It should be simple enough to grab a reference to the current isolate when the module is loaded and then compare against that in the segfault handler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant