Static Module Doesn't Play Nice With ESLint

[0xcaff]

Hello,

When using protobufjs with my react project, I get eslint errors in the file generated using pbjs -t static-module. Here's a gist with my generated file and eslint errors. https://gist.github.com/caffinatedmonkey/918e7fddc80f7c0dc31be0f7fb59966c

The first few errors are caused by the wrapper. It would be nice to have some built-in ones for just commonjs or amd only which also play nice with eslinr under the -t flag.

The ones about reader being undefined seem valid.

Awesome project by the way!

[dcodeIO]

Refactored this a bit and added a few eslint comments to meet your needs. Try again!

[0xcaff]

Now I get this error:

Error in ./src/proto.js
Module not found: 'protobuf' in /home/drone/go/src/github.com/caffinatedmonkey/dos/frontend/src

 @ ./src/proto.js 8:61-90

It's caused by the wrapper:

(function(global, factory) {
    /* eslint-disable no-undef */

    /* AMD */ if (typeof define === 'function' && define.amd)
        define(["protobuf"], factory); // commenting out this line makes the errors go away.

    /* CommonJS */ else if (typeof require === 'function' && typeof module === 'object' && module && module.exports)
        module.exports = factory(require("protobufjs/runtime"));

    /* eslint-enable no-undef */

[0xcaff]

Also, when fix the wrapper by removing everything except commonjs, I then get a warning about $prototype at:

    /** @alias dos */
    $root.dos = (function() {

        /** @alias dos */
        var dos = {};

        /** @alias dos.DrawMessage */
        dos.DrawMessage = (function() {

            /**
             * Constructs a new DrawMessage.
             * @exports dos.DrawMessage
             * @constructor
             * @param {Object} [properties] Properties to set
             */
            function DrawMessage(properties) {
                if (properties) {
                    var keys = Object.keys(properties);
                    for (var i = 0; i < keys.length; ++i)
                        this[keys[i]] = properties[keys[i]];
                }
            }

            /** @alias dos.DrawMessage.prototype */
            var $prototype = DrawMessage.prototype; // warning unused $prototype

It can be fixed by removing that line or adding the // eslint-disable-next-line no-unused-vars comment to the line above.

[dcodeIO]

Here you go:

$> pbjs -t static-module -w commonjs ...

[0xcaff]

Thanks! Everything works now! 👍