Other: aspromise performance pass

protobufjs · Apr 24, 2017 · 7445da0 · 7445da0
1 parent 3f8b74b
commit 7445da0
Show file tree

Hide file tree

Showing 18 changed files with 107 additions and 68 deletions.
diff --git a/dist/light/protobuf.js b/dist/light/protobuf.js
diff --git a/dist/light/protobuf.js.map b/dist/light/protobuf.js.map
diff --git a/dist/light/protobuf.min.js b/dist/light/protobuf.min.js
diff --git a/dist/light/protobuf.min.js.gz b/dist/light/protobuf.min.js.gz
diff --git a/dist/light/protobuf.min.js.map b/dist/light/protobuf.min.js.map
diff --git a/dist/minimal/protobuf.js b/dist/minimal/protobuf.js
diff --git a/dist/minimal/protobuf.js.map b/dist/minimal/protobuf.js.map
diff --git a/dist/minimal/protobuf.min.js b/dist/minimal/protobuf.min.js
diff --git a/dist/minimal/protobuf.min.js.gz b/dist/minimal/protobuf.min.js.gz
diff --git a/dist/minimal/protobuf.min.js.map b/dist/minimal/protobuf.min.js.map
diff --git a/dist/protobuf.js b/dist/protobuf.js
diff --git a/dist/protobuf.js.map b/dist/protobuf.js.map
diff --git a/dist/protobuf.min.js b/dist/protobuf.min.js
diff --git a/dist/protobuf.min.js.gz b/dist/protobuf.min.js.gz
diff --git a/dist/protobuf.min.js.map b/dist/protobuf.min.js.map
diff --git a/lib/aspromise/index.js b/lib/aspromise/index.js
@@ -19,26 +19,29 @@ module.exports = asPromise;
  * @returns {Promise<*>} Promisified function
  */
 function asPromise(fn, ctx/*, varargs */) {
-    var params = [];
-    for (var i = 2; i < arguments.length;)
-        params.push(arguments[i++]);
-    var pending = true;
-    return new Promise(function asPromiseExecutor(resolve, reject) {
-        params.push(function asPromiseCallback(err/*, varargs */) {
+    var params  = new Array(arguments.length - 1),
+        offset  = 0,
+        index   = 2,
+        pending = true;
+    while (index < arguments.length)
+        params[offset++] = arguments[index++];
+    return new Promise(function executor(resolve, reject) {
+        params[offset] = function callback(err/*, varargs */) {
             if (pending) {
                 pending = false;
                 if (err)
                     reject(err);
                 else {
-                    var args = [];
-                    for (var i = 1; i < arguments.length;)
-                        args.push(arguments[i++]);
-                    resolve.apply(null, args);
+                    var params = new Array(arguments.length - 1),
+                        offset = 0;
+                    while (offset < params.length)
+                        params[offset++] = arguments[offset];
+                    resolve.apply(null, params);
                 }
             }
-        });
+        };
         try {
-            fn.apply(ctx || this, params); // eslint-disable-line no-invalid-this
+            fn.apply(ctx || null, params);
         } catch (err) {
             if (pending) {
                 pending = false;

diff --git a/lib/aspromise/package.json b/lib/aspromise/package.json
@@ -1,7 +1,7 @@
 {
   "name": "@protobufjs/aspromise",
   "description": "Returns a promise from a node-style callback function.",
-  "version": "1.1.1",
+  "version": "1.1.2",
   "author": "Daniel Wirtz <[email protected]>",
   "repository": {
     "type": "git",

diff --git a/package.json b/package.json
@@ -45,7 +45,7 @@
   },
   "dependencies": {
     "long": "^3.2.0",
-    "@protobufjs/aspromise": "^1.1.1",
+    "@protobufjs/aspromise": "^1.1.2",
     "@protobufjs/base64": "^1.1.1",
     "@protobufjs/codegen": "^2.0.3",
     "@protobufjs/eventemitter": "^1.1.0",