Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle configuration triggered errors on UPS creation on completion of previous UPS gracefully #3782

Closed
vrindanayak opened this issue Aug 22, 2022 · 0 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@vrindanayak
Copy link
Member

Rationale : If archive is configured to create a new UPS on completion of a previous UPS using a configured UPS on UPS Completed rule, with following configs

and, Change Workitem State is invoked, wherein the UPS whose state is being changed to COMPLETED does not contain Output Information Sequence and / or Referenced Request Sequence, the service throws

< HTTP/1.1 500 Internal Server Error
< Access-Control-Allow-Headers: origin, content-type, accept, authorization
< Warning: 299 http://localhost:8880/dcm4chee-arc/aets/DCM4CHEE/rs/workitems: java.lang.NullPointerException

even if previous UPS state was successfully changed to COMPLETED

Instead, improve the behaviour by logging the information of incorrect configuration and state of attributes of previous UPS, allowing the invoked service to return 200 - Ok for successful state change of previous UPS to COMPLETED.

@vrindanayak vrindanayak added the bug Something isn't working label Aug 22, 2022
@vrindanayak vrindanayak added this to the 5.28.0 milestone Aug 22, 2022
@vrindanayak vrindanayak self-assigned this Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant