-
-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for GoogleDriveLoader #71
Comments
@davidmigloz I am interested in working on adding this support so can you assign this to me. Also, Can you share any relevant reference other than the official documentation (above python codebase reference link is broken). And yes, Is there any specific time period under which I have to complete this functionality ? I saw @faithoflifedev has worked on some of the document loader implementations and this is my first interaction with this repo. Will you be interested in sharing any piece of advice or suggestions on this. |
hey @Sahil-kachhap , Happy to hear that you are willing to collaborate with the project! 🙂 I've just fixed the links that point to the LangChain Python documentation and implementation. I would recommend that you take a look to it, then get familiar with the googleapis package and finally look at some of the other document loaders implementations to have a reference. There is no specific deadlines for this feature, so no pressure. If you have any question or need more guidance don't hesitate to ask in the #contributing channel of our Discord Server, (or in this issue). |
Hi @Sahil-kachhap, I'll help where I can. I've worked with the googleapis_auth package in my yt package that wraps a lot of the Youtube APIs. I've been hesitant to start on any cloud file system loaders, since I really haven't had the time to research how they deal with different file types (CSV, JSON, etc.) so I figured my time was better spent on the individual file types thinking that these might need to be integrated into a cloud loader. |
[Need Review of below code snippet]: Dart Implementation of loadCredential Method@faithoflifedev @davidmigloz here is a snippet of loadCredentials method that returns an authenticated HTTP client which can then be used by all other methods to interact with Google APIs:-
|
@Sahil-kachhap thanks for your work. I think it's better if LangChain.dart is not responsible for the authentication/authorization part, but delegates that to googleapis_auth package. As there are many ways you may want to authenticate depending on your use case. I would make the loader require a That's the strategy I've followed for implementing the Vertex AI API client. Let me know if that makes sense to you. By the way, I forgot to mention that the |
HI @Sahil-kachhap , no comments on the code specifically. More generally, my approach to this type of scenario was to use different |
Oh yes that really makes sense @davidmigloz . Got it, I will now add the AuthClient in the constructor and yes will move the current progress in the code to that relevant package (langchain_google). |
@faithoflifedev Oh Yeah that's a good approach too but since I created the class for googledriveloader functionality, I doubted, whether to place all these auth methods in the same place as other loader methods. Like I wanted to keep all stuffs focused towards loader functionality (Single Responsibility Principle) |
We can always add convenient factory constructors later on if needed, but I would keep it simple for now. |
Dart packages:
The text was updated successfully, but these errors were encountered: