refactor!: Change push model status type from enum to String #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmigloz
added a commit
that referenced
this pull request
Jul 12, 2024
KennethKnudsen97
pushed a commit
to KennethKnudsen97/langchain_dart
that referenced
this pull request
Oct 1, 2024
KennethKnudsen97
pushed a commit
to KennethKnudsen97/langchain_dart
that referenced
this pull request
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ollama push model status values are not standarized as enums in the Ollama codebase, instead, they are just messages that are printed in different parts of the codebase. E.g.;
https://github.com/ollama/ollama/blob/e5c65a85df21a78052bb9f46bdb37bf6838644f7/server/images.go#L805-L807
Initially in the
ollama_dartclient, we made thestatusfield an enum. However, its values were not exhaustive and varied in different versions of Ollama. That's why we decided to change its type to string.