fix(agent): openai function agent infinite loop issue #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The prompt of the default LLMChain has a wrong order when no memory and causing infinite loop of function call.
davidmigloz
added
t:bug
davidmigloz
approved these changes
Aug 20, 2023
|
Good catch! Thanks for the fix, lgtm 👍 |
KennethKnudsen97
pushed a commit
to KennethKnudsen97/langchain_dart
that referenced
this pull request
Sep 29, 2023
…avidmigloz#134) The prompt built by the agent has a wrong order of messages when no memory is used which causes an infinite loop of function calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: The prompt of the default LLMChain(
OpenAIFunctionsAgent.fromLLMAndTools) has a wrong order when no memory and causing infinite loop of function call.Issue: infinite loop of function call with OpenAIFunctionsAgent
Tag maintainer: @davidmigloz
Background:
When using
OpenAIFunctionsAgent.fromLLMAndToolsandmemory == null,createPromptwill create prompt with the following order:Even when the agent finishes the task, GPT appears to trigger the function repeatedly because the last message is a Human message.
Example of
promptValuethat calling infinite loop:Solution:
I change the default order of
createPromptwhen no memory to the following and the issue is gone.