Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: add macOS and Windows builds to GitHub Actions, fix LC_ALL warning in Guix container, introduce artifact collection script for GitHub Actions #6421

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from

Conversation

kwvg
Copy link
Collaborator

@kwvg kwvg commented Nov 21, 2024

Additional Information

  • Depends on ci: merge bitcoin#27314, #28954, #29765, introduce dependency options in GitHub Actions builds, fix multiprocess builds #6400
  • WINEPREFIX needs to be overridden because of permissions issues with GitHub Actions (build), SC2155 (info) has been suppressed as the expected syntax is clunky and unnecessary (if mktmp fails, wine would refuse to run due to invalid WINEPREFIX, which would trigger an error).
  • The HOST check before running setup_sdk.sh isn't a part of the shell script itself as the script is written to not have to rely on external variables being set, so the caller is expected to know the conditions it'll impose to run setup_sdk.sh, the script itself remaining agnostic.
    • guix-start doesn't benefit from deduplication because the scripts there are expected to be self-contained and therefore, cannot link back to this script as it will not be present in the container.

Breaking Changes

None expected.

Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (note: N/A)
  • I have added or updated relevant unit/integration/functional/e2e tests (note: N/A)
  • I have made corresponding changes to the documentation (note: N/A)
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@kwvg kwvg added this to the 22.1 milestone Nov 21, 2024
@kwvg
Copy link
Collaborator Author

kwvg commented Nov 21, 2024

@kwvg kwvg force-pushed the add_mac_win branch 3 times, most recently from 20d87fb to fe08442 Compare November 22, 2024 13:31
@kwvg
Copy link
Collaborator Author

kwvg commented Nov 22, 2024

@kwvg kwvg changed the title ci: add macOS and Windows builds to GitHub Actions ci: add macOS and Windows builds to GitHub Actions, fix LC_ALL warning in Guix container, introduce artifact collection script Nov 22, 2024
@kwvg kwvg changed the title ci: add macOS and Windows builds to GitHub Actions, fix LC_ALL warning in Guix container, introduce artifact collection script ci: add macOS and Windows builds to GitHub Actions, fix LC_ALL warning in Guix container, introduce artifact collection script for GitHub Actions Nov 22, 2024
@kwvg
Copy link
Collaborator Author

kwvg commented Nov 23, 2024

Copy link

This pull request has conflicts, please rebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant