forked from bitcoin/bitcoin
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: add macOS and Windows builds to GitHub Actions, fix LC_ALL warning in Guix container, introduce artifact collection script for GitHub Actions #6421
Draft
kwvg
wants to merge
9
commits into
dashpay:develop
Choose a base branch
from
kwvg:add_mac_win
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+367
−167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitHub Actions run for 66b7197, https://github.com/kwvg/dash/actions/runs/11955577182. |
Also, remove `version` from `docker-compose.yml` because `version` has been deprecated.
kwvg
force-pushed
the
add_mac_win
branch
3 times, most recently
from
November 22, 2024 13:31
20d87fb
to
fe08442
Compare
GitHub Actions run for fe08442, https://github.com/kwvg/dash/actions/runs/11973573180 |
kwvg
changed the title
ci: add macOS and Windows builds to GitHub Actions
ci: add macOS and Windows builds to GitHub Actions, fix LC_ALL warning in Guix container, introduce artifact collection script
Nov 22, 2024
kwvg
changed the title
ci: add macOS and Windows builds to GitHub Actions, fix LC_ALL warning in Guix container, introduce artifact collection script
ci: add macOS and Windows builds to GitHub Actions, fix LC_ALL warning in Guix container, introduce artifact collection script for GitHub Actions
Nov 22, 2024
GitLab Actions run for a5959da, https://github.com/kwvg/dash/actions/runs/11976668589. |
This pull request has conflicts, please rebase. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional Information
WINEPREFIX
needs to be overridden because of permissions issues with GitHub Actions (build), SC2155 (info) has been suppressed as the expected syntax is clunky and unnecessary (ifmktmp
fails,wine
would refuse to run due to invalidWINEPREFIX
, which would trigger an error).HOST
check before runningsetup_sdk.sh
isn't a part of the shell script itself as the script is written to not have to rely on external variables being set, so the caller is expected to know the conditions it'll impose to runsetup_sdk.sh
, the script itself remaining agnostic.guix-start
doesn't benefit from deduplication because the scripts there are expected to be self-contained and therefore, cannot link back to this script as it will not be present in the container.Breaking Changes
None expected.
Checklist