Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fee market: Charge extra dispatch fee on target chain according to message.weight #30

Open
hackfisher opened this issue Jun 17, 2022 · 2 comments

Comments

@hackfisher
Copy link
Collaborator

In send message or in fee market,

The max usable balance from relayer for evm message should not be large before this fixed.

@hackfisher
Copy link
Collaborator Author

@wuminzhe
Copy link

wuminzhe commented Jun 23, 2022

the most call's weight can be calculated for users:

(bytes memory call, uint64 weight) = DarwiniaCalls.system_remarkWithEvent(hex"12345678");

https://github.com/darwinia-network/darwinia-messages-sol/blob/785b9fc3f365699eb8be26574dd7e11185e2151a/contracts/periphery/contracts/s2s/examples/RemarkDemo.sol#L23

but for message_transact call, we should limit the gas because the weight is from the gas limit inputted by the user. use MAX_GAS_PER_MESSAGE?
darwinia-network/darwinia-messages-sol#171

@hackfisher hackfisher changed the title Charge extra dispatch fee on target chain according to message.weight Fee market: Charge extra dispatch fee on target chain according to message.weight Jun 23, 2022
@hackfisher hackfisher transferred this issue from darwinia-network/darwinia-messages-substrate Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

No branches or pull requests

3 participants
@hackfisher @wuminzhe and others