Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird wrapping in the header for some generic classes #3407

Open
Hixie opened this issue May 4, 2023 · 2 comments
Open

Weird wrapping in the header for some generic classes #3407

Hixie opened this issue May 4, 2023 · 2 comments
Labels
area-web-design Something a web designer interested in helping could do. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)

Comments

@Hixie
Copy link
Contributor

Hixie commented May 4, 2023

e.g.
https://master-api.flutter.dev/flutter/rendering/ContainerRenderObjectMixin-mixin.html
...looks like this:
2023-05-03-175120_1408x161_scrot

@srawlins
Copy link
Member

srawlins commented May 4, 2023

Oof, I almost fell out of my seat looking at that. Good find.

Some preliminary notes:

  • This flex layout, mixed with horizontal list items and white-space: nowrap is a little weird... probably deserves a refactoring into something... simpler?
  • adding flex: 1 to the ol.breadcrumbs improves the UI.
  • adding white-space: normal to .signature also helps.
  • dropping white-space: nowrap from span.type-parameter I think also helps.
  • I think we're managing too much of the layout with white-space:. That's an uphill battle.

@srawlins srawlins added type-bug Incorrect behavior (everything from a crash to more subtle misbehavior) P2 A bug or feature request we're likely to work on area-web-design Something a web designer interested in helping could do. labels May 4, 2023
@jcollins-g
Copy link
Contributor

Yikes. I think in general having type information in the breadcrumbs is going to lead to trouble, particularly if the information is repeated in the header right below it. Maybe we can "fix" this by removing type parameters from breadcrumbs and linkifying the header. A further refinement might be to separate out the type parameters from the header somehow so that the header doesn't have similar readability problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-web-design Something a web designer interested in helping could do. P2 A bug or feature request we're likely to work on type-bug Incorrect behavior (everything from a crash to more subtle misbehavior)
Projects
None yet
Development

No branches or pull requests

3 participants