-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State ETag support with HTTP protocol #540
Comments
Hi @heunghingwan, the ETAG comes back in the response header which we seem to be ignoring/dropping. Only the response body is being returned as Key-Value pairs via To be backward compatible, I propose a new method async getState(statestore: string, key: string, options?: Partial<StateGetOptions>): Promise<GetStateResponse> {};
type GetStateResponse = {
key: string,
value: KeyValueType;
etag?: string;
}; We can also add a deprecation notice to |
@XavierGeerinck what are your thoughts? |
maybe with |
After discussing with Xavier offline, I am also in favor of |
This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in the next 7 days unless it is tagged (pinned, good first issue, help wanted or triaged/resolved) or other activity occurs. Thank you for your contributions. |
Describe the proposal
State ETag support has been added in #476, but it is limited to the grpc protocol. When using the http protocol, the ETag cannot be obtained through the get function.
Not sure how to change it in a backwards compatible way, may be with a new function like
getWithMetadata
?The text was updated successfully, but these errors were encountered: