Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add in coveralls CI code coverage tracking #136

Closed
danmayer opened this issue Nov 11, 2018 · 4 comments
Closed

add in coveralls CI code coverage tracking #136

danmayer opened this issue Nov 11, 2018 · 4 comments

Comments

@danmayer
Copy link
Owner

While our tests output code coverage it is a bit had to visualize and compare coverage over time... Let's add in https://coveralls.io/ support to our CI test runs to make it easy to see that we are maintaining and increasing our coverage.

added as help wanted / good first issue to see if we can get some more contributors ;)

@dondonz
Copy link
Contributor

dondonz commented Dec 25, 2018

Hello! If this hasn't already been taken, I would like to help.

@danmayer
Copy link
Owner Author

That would be awesome @dondonz let us know if you need anything to get started

@dondonz dondonz mentioned this issue Dec 29, 2018
1 task
@dondonz
Copy link
Contributor

dondonz commented Dec 29, 2018

Thanks!

I've given it a go (PR #157), please let me know what you think.

I have two questions.

  1. Could someone please log into Coveralls and add the Coverband repo? Perhaps you've already done this 😄
  2. Could I confirm - would you like to retain SimpleCov in the test_helper.rb file? I have not changed any SimpleCov settings.

@danmayer
Copy link
Owner Author

hmm good call not sure if I still need SimpleCov I will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants