Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make semantic-release an option #4

Open
macklinu opened this issue May 18, 2017 · 3 comments
Open

Make semantic-release an option #4

macklinu opened this issue May 18, 2017 · 3 comments

Comments

@macklinu
Copy link
Member

This generator is pretty specific to my personal workflow, so it might be nice to make semantic-release integration an option.

As part of this option, though, it would be cool that once all dependencies are installed, the generator will cd into the newly created directory and run semantic-release-cli setup as the final step.

@danpalmer
Copy link

Hi, +1 for this. I've just tried to set up a new project and am pretty confused right now. I'll probably end up deleting all the git commit tooling and auto-release stuff because I have Sublime set up to do my commits, and it seems the special commit wording is needed for the auto release?

@julon
Copy link

julon commented Jan 16, 2018

Hi @macklinu, for that you would just need to remove the .travis.yml and semantic-release from package.json since they are created/overwritten by the cli anyway? I would not remove conventional-changelog though, since the whole point is to automate the maximum by enforcing semantic-release ? (changelog generation, github release, npm deploy, etc)

@macklinu
Copy link
Member Author

I'm not sure this tool should force developers to release with semantic-release. Perhaps there could be a yes/no prompt "Would you like to setup semantic-release?". If yes, add the semantic-release dependencies, set up commit message validation (using conventional-changelog), and run semantic-release-cli setup as the final step. Otherwise, leave all of that stuff out (which I think would have been caused less confusion in your experience, @danpalmer 👍 ).

Thoughts on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants