Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Kingfisher to 8.0.3 (or backport b4837a97d to our version) #2544

Open
danieldaquino opened this issue Sep 24, 2024 · 0 comments
Open

Comments

@danieldaquino
Copy link
Contributor

On iOS 18 there was a regression where we could not tap some Kingfisher image elements. (See #2370 and #2342)

We fixed this issue with #2498, however the developer needs to remember to set the .kfClickable() modifier to every KFAnimatedImage call to avoid this problem.

A better fix was created and applied on Kingfisher 8.0.3 (onevcat/Kingfisher@b4837a9) (See issue onevcat/Kingfisher#2295).

Although the tapping problem was solved on our end, so this is low-priority, it would technically be better to revert this fix and either upgrade to Kingfisher 8.0.3, or to backport this fix to our current Kingfisher version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant