[dagster-k8s] per_step_k8s_config working with dynamic jobs #26670
+91
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & Motivation
Allow run time configuration of dynamic steps using the
k8s_job_executor
. Previously, dynamic steps would not be configured when usingper_step_k8s_config
. Now doing something along line of the following:Given the following job:
Will configure all
dyn_sink
ops with the following modified config.cc @Kuhlwein
resolves #26588
How I Tested These Changes
Red green coverage given a dynamic job. Revert the following line to watch the test fail.